-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#342] RAG - fix PDF format in vector database #551
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
43119ce
to
de97100
Compare
de97100
to
da035d6
Compare
61376bf
to
9bba3e4
Compare
@pytest.mark.asyncio | ||
async def test_downloads_pdf_and_returns_content(self): | ||
# Using GitHub to host the PDF file | ||
url = "https://raw.githubusercontent.com/meta-llama/llama-stack/da035d69cfca915318eaf485770a467ca3c2a238/llama_stack/providers/tests/memory/fixtures/dummy.pdf" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did consider mocking but that would have introduced another dep that we don't have + make the test less realistic. So decided to do this.
But lmk if you prefer mocking here
4c55e2e
to
acdf4cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, thanks!!
What does this PR do?
Addresses issue (#342)
Test Plan
Ran these unit tests:
Tested manually via this script to initialize and this script to query
Should output valid text chunks
Before submitting
Pull Request section?